HighFile-scopePython Plug & play

Avoid Functions That Always Return the Same Value

Identify functions that return the same value regardless of input. This may indicate poor design or a logic error.

Why this matters

If a function always returns the same value regardless of input, it may indicate poor design or a logic error.

Side-by-side examples engineers can pattern-match during review.

Avoid

def foo(a):  # NonCompliant
    b = 12
    if a == 1:
        return b
    return b

Prefer

// (no example provided)

Bad

def foo(a):  # NonCompliant
    b = 12
    if a == 1:
        return b
    return b

From the same buckets as this rule.

Critical
Avoid Duplicating String Literals
Store repeated string literals in constants or variables to improve maintainability and reduce redundancy.
duplication-complexitymaintainability
Critical
Avoid Redundant `None` Comparisons
Identify cases where `x is None` or `x is not None` is used redundantly when `x` is always or never `None`. This may indicate a deeper logic issue.
duplication-complexityreadability-refactor+1
High
Avoid Unnecessary `toList()` with Spread Operator
Remove unnecessary calls to `.toList()` when using the spread operator (`...`) as it is already designed to work with iterable collections.
duplication-complexityperformance-efficiency+1