HighFile-scopeDart Plug & play

Avoid Unnecessary `toList()` with Spread Operator

Remove unnecessary calls to `.toList()` when using the spread operator (`...`) as it is already designed to work with iterable collections.

Why this matters

The spread operators (`...` and `...?`) can flatten collections directly, making `toList()` redundant and less efficient.

Side-by-side examples engineers can pattern-match during review.

Avoid

final list = [
    1,
    2,
    ...anIterable.toList(), // Noncompliant
    3,
    4
];

Prefer

final list = [
    1,
    2,
    ...anIterable,
    3,
    4
];

Bad

final list = [
    1,
    2,
    ...anIterable.toList(), // Noncompliant
    3,
    4
];

Good

final list = [
    1,
    2,
    ...anIterable,
    3,
    4
];

From the same buckets as this rule.

Critical
Avoid Duplicating String Literals
Store repeated string literals in constants or variables to improve maintainability and reduce redundancy.
duplication-complexitymaintainability
Critical
Avoid Redundant `None` Comparisons
Identify cases where `x is None` or `x is not None` is used redundantly when `x` is always or never `None`. This may indicate a deeper logic issue.
duplication-complexityreadability-refactor+1
High
Avoid Functions That Always Return the Same Value
Identify functions that return the same value regardless of input. This may indicate poor design or a logic error.
duplication-complexityreadability-refactor+1