CriticalFile-scopePython Plug & play

Avoid Redundant `None` Comparisons

Identify cases where `x is None` or `x is not None` is used redundantly when `x` is always or never `None`. This may indicate a deeper logic issue.

Why this matters

Checking `x is None` when `x` is always `None` (or never `None`) is unnecessary and may indicate a deeper logic issue.

Side-by-side examples engineers can pattern-match during review.

Avoid

def foo():
    my_var = None
    if my_var == None:  # Noncompliant: always True.
        ...

Prefer

def foo(my_var):
    if my_var == None:
        ...

Bad

def foo():
    my_var = None
    if my_var == None:  # Noncompliant: always True.
        ...

Good

def foo(my_var):
    if my_var == None:
        ...

From the same buckets as this rule.

Critical
Avoid Duplicating String Literals
Store repeated string literals in constants or variables to improve maintainability and reduce redundancy.
duplication-complexitymaintainability
High
Avoid Functions That Always Return the Same Value
Identify functions that return the same value regardless of input. This may indicate poor design or a logic error.
duplication-complexityreadability-refactor+1
High
Avoid Unnecessary `toList()` with Spread Operator
Remove unnecessary calls to `.toList()` when using the spread operator (`...`) as it is already designed to work with iterable collections.
duplication-complexityperformance-efficiency+1