// library

Testing & Quality rules

16 rules

Severity

Bucket

ActiveBucketTesting & Quality Clear all

Critical
No live network or DB in unit tests—use fakes/mocks
Unit tests must stub or fake external HTTP/DB calls; allow real I/O only in integration/e2e tests tagged accordingly.
testing-qualityperformance-efficiency+1
High
Behavioral changes must add or update tests
If files under src/ change behavior, the PR must include tests/ updates or a PR description line no-tests: <reason> explaining why tests are unaffected.
testing-qualitypr-hygiene
High
Block real PAN/SAD in fixtures and test data
Reject PRs adding real PAN/CVV in fixtures, seeds, or mocks. Only use Luhn-valid test PANs from the gateway or opaque tokens (e.g., tok_) and never include CVV. Add a check to fail if a PAN regex is matched. (PCI DSS data minimization)
compliance-pci-dsstesting-quality+1
High
Enforce minimum coverage in CI
CI must fail the build when line coverage drops below the project threshold (e.g., 80%); publish coverage reports as artifacts.
testing-qualityci-cd-build-hygiene
High
Freeze time and random sources for deterministic tests
In unit and integration tests, call a time-freeze utility and set a fixed random seed before exercising the system under test; unfreeze after assertions.
testing-quality
High
Go: parallel-safe tests with t.Parallel and t.TempDir
Mark tests that don't mutate shared state with t.Parallel() and use t.TempDir() for filesystem isolation; avoid package-level globals.
testing-qualityconcurrency-safety
High
Include testing evidence or steps-to-reproduce
Provide explicit verification steps (manual or automated), expected vs actual outcomes, and attach any logs or screenshots relevant to the changes.
pr-hygienetesting-quality
High
Jest: use async/await and resolves/rejects instead of done()
For Promises, return/await the expectation and prefer await expect(p).resolves|rejects...; do not use the callback done().
testing-quality
High
Kotlin coroutines: use runTest and avoid Thread.sleep
Test suspend code with kotlinx-coroutines-test runTest {} and virtual time (advanceUntilIdle()); do not block with Thread.sleep.
testing-quality
High
RSpec: stub external HTTP and assert on effects
Use WebMock or equivalent to stub external requests in specs and prefer effect-based matchers (e.g., change(Model, :count)) over brittle value guesses.
testing-quality
High
xUnit: async tests return Task and avoid Thread.Sleep
In async tests, return Task and await the operation; never use Thread.Sleep—use cancellation tokens or timeouts with Assert.ThrowsAsync where needed.
testing-quality
Low
Add a reviewer checklist in the PR
Provide a short checklist tailored to this change (e.g., 'logic matches spec', 'docs updated', 'flags in place', 'rollback plan noted').
pr-hygienetesting-quality+1
Low
JUnit 5: assertThrows and timeouts for slow paths
Use assertThrows for exception cases and annotate long-running tests with @Timeout to bound execution; use @TempDir for file I/O.
testing-quality
Low
PHPUnit: use data providers and type-strict assertions
Prefer data providers for parameterized cases and use assertSame/assertNotSame for type-strict checks; avoid loose equals.
testing-qualitystyle-conventions
Low
Provide loading.tsx and error.tsx per segment
For async routes, add loading.tsx for suspense fallbacks and error.tsx for boundaries. Use notFound() for 404 states.
stack-nextjsstack-react+2
Low
Rust async tests: use #[tokio::test] and avoid unwrap()
For async code, annotate with #[tokio::test] (or async runtime in use) and return Result from tests; never use unwrap()/expect() in assertions.
testing-quality

16 rules

No live network or DB in unit tests—use fakes/mocks

Behavioral changes must add or update tests

Block real PAN/SAD in fixtures and test data

Enforce minimum coverage in CI

Freeze time and random sources for deterministic tests

Go: parallel-safe tests with t.Parallel and t.TempDir

Include testing evidence or steps-to-reproduce

Jest: use async/await and resolves/rejects instead of done()

Kotlin coroutines: use runTest and avoid Thread.sleep

RSpec: stub external HTTP and assert on effects

xUnit: async tests return Task and avoid Thread.Sleep

Add a reviewer checklist in the PR

JUnit 5: assertThrows and timeouts for slow paths

PHPUnit: use data providers and type-strict assertions

Provide loading.tsx and error.tsx per segment

Rust async tests: use #[tokio::test] and avoid unwrap()

No live network or DB in unit tests—use fakes/mocks

Behavioral changes must add or update tests

Block real PAN/SAD in fixtures and test data

Enforce minimum coverage in CI

Freeze time and random sources for deterministic tests

Go: parallel-safe tests with t.Parallel and t.TempDir

Include testing evidence or steps-to-reproduce

Jest: use async/await and resolves/rejects instead of done()

Kotlin coroutines: use runTest and avoid Thread.sleep

RSpec: stub external HTTP and assert on effects

xUnit: async tests return Task and avoid Thread.Sleep

Add a reviewer checklist in the PR

JUnit 5: assertThrows and timeouts for slow paths

PHPUnit: use data providers and type-strict assertions

Provide loading.tsx and error.tsx per segment

Rust async tests: use #[tokio::test] and avoid unwrap()