HighFile-scopeDart Plug & play

Avoid Using Constant Patterns with Type Literals

Do not use constant patterns with type literals as it can lead to unexpected behavior. Prefer direct type checking instead.

Why this matters

Using constant patterns with type literals can lead to incorrect assumptions and unintended behavior.

Side-by-side examples engineers can pattern-match during review.

Avoid

bool isANumber(Object? o) {
  if (o case num) {
    return true;
  }
  return false;
}

Prefer

bool isANumber(Object? o) {
  if (o case num _) {
    return true;
  }
  return false;
}

Bad

bool isANumber(Object? o) {
  if (o case num) {
    return true;
  }
  return false;
}

Good

bool isANumber(Object? o) {
  if (o case num _) {
    return true;
  }
  return false;
}

From the same buckets as this rule.

Critical
Avoid equality operators in loop termination conditions
Check if loops use equality operators (== or !=) in termination conditions. These can lead to infinite loops if the condition is never met exactly. Instead, use relational operators like < or > for safer loop termination.
error-handlingreadability-refactor
Critical
Avoid Returning Null in Non-Async Task Methods
Returning null from a Task or Task<T> method causes a NullReferenceException if awaited. Use Task.CompletedTask or Task.FromResult<T>(null) instead.
error-handlingreadability-refactor+1
Critical
Avoid Using Boolean Expressions in `except` Statements
Detect `except` clauses that use `or` or `and` to catch multiple exceptions. This does not work as intended. Recommend using a tuple of exceptions instead.
error-handlingstack-python