HighFile-scopeC# Plug & play

Limit Lengthy LINQ Chains

Verify that LINQ queries are not excessively long. Break complex queries into smaller, more understandable expressions.

Why this matters

Overly long LINQ queries reduce readability and make debugging difficult. Break them into smaller, more understandable expressions.

Bad vs. good

Side-by-side examples engineers can pattern-match during review.

Avoid

var result = someList.Where(x => x.IsValid).OrderBy(x => x.Name).Select(x => x.Value).ToList();

Prefer

var validItems = someList.Where(x => x.IsValid);
var orderedItems = validItems.OrderBy(x => x.Name);
var result = orderedItems.Select(x => x.Value).ToList();

More snippets

Bad

var result = someList.Where(x => x.IsValid).OrderBy(x => x.Name).Select(x => x.Value).ToList();

Good

var validItems = someList.Where(x => x.IsValid);
var orderedItems = validItems.OrderBy(x => x.Name);
var result = orderedItems.Select(x => x.Value).ToList();

Related rules

From the same buckets as this rule.

Critical
Avoid Duplicating String Literals
Store repeated string literals in constants or variables to improve maintainability and reduce redundancy.
duplication-complexitymaintainability
Critical
Avoid Redundant `None` Comparisons
Identify cases where `x is None` or `x is not None` is used redundantly when `x` is always or never `None`. This may indicate a deeper logic issue.
duplication-complexityreadability-refactor+1
High
Avoid Functions That Always Return the Same Value
Identify functions that return the same value regardless of input. This may indicate poor design or a logic error.
duplication-complexityreadability-refactor+1

Why this matters

Bad vs. good

More snippets

Related rules

Avoid Duplicating String Literals

Avoid Redundant `None` Comparisons

Avoid Functions That Always Return the Same Value

Why this matters

Bad vs. good

More snippets

Related rules

Avoid Duplicating String Literals

Avoid Redundant `None` Comparisons

Avoid Functions That Always Return the Same Value