HighFile-scopeJava Plug & play

Prefer dependency injection over manual factories

Obtain collaborators via constructor injection (or a DI container) instead of new/service locators in business code.

Why this matters

Improves testability, configuration, and lifecycle management.

Side-by-side examples engineers can pattern-match during review.

Avoid

PaymentService svc = new PaymentService(new HttpClient());

Prefer

class OrderHandler {
  private final PaymentService payments;
  OrderHandler(PaymentService payments) { this.payments = payments; }
}

Bad

var repo = Factories.getRepo()

Good

new Handler(Repo repo)

From the same buckets as this rule.

Critical
Require an ADR for any architectural or cross-team decision
For changes that affect architecture, data models, external APIs, security posture, deployment topology, or cost (>10%), create an ADR in docs/adr/ using the standard template (Context, Decision, Consequences) and link the PR and issue IDs.
docs-adrsmodule-architecture+1
Critical
Use Factory Method Injection in `@Configuration` Classes
Ensure that factory method injection is used in `@Configuration` classes instead of `@Autowired` field injection.
module-architecturestyle-conventions
High
A module should not import itself
Identify cases where a module imports itself. Self-imports are usually unintentional and can cause confusion or unnecessary dependencies. Suggest removing them.
module-architecture