HighFile-scopePHP Plug & play

Throw exceptions on job failures

Background jobs must throw on irrecoverable failures (after logging) so the runner/queue can retry or dead-letter appropriately.

Why this matters

Swallowed errors make queues appear healthy while losing work.

Side-by-side examples engineers can pattern-match during review.

Avoid

try { handleJob($job); } catch (Throwable $e) { $logger->error($e->getMessage()); /* swallow */ }

Prefer

try { handleJob($job); } catch (Throwable $e) {
    $logger->error('job failed', ['jobId'=>$job->id, 'e'=>$e]);
    throw $e; // trigger retry/DLQ
}

Bad

catch(Throwable $e){ /* log only */ }

Good

catch(Throwable $e){ $logger->error(...); throw $e; }

From the same buckets as this rule.

Critical
Avoid equality operators in loop termination conditions
Check if loops use equality operators (== or !=) in termination conditions. These can lead to infinite loops if the condition is never met exactly. Instead, use relational operators like < or > for safer loop termination.
error-handlingreadability-refactor
Critical
Avoid Returning Null in Non-Async Task Methods
Returning null from a Task or Task<T> method causes a NullReferenceException if awaited. Use Task.CompletedTask or Task.FromResult<T>(null) instead.
error-handlingreadability-refactor+1
Critical
Avoid Using Boolean Expressions in `except` Statements
Detect `except` clauses that use `or` or `and` to catch multiple exceptions. This does not work as intended. Recommend using a tuple of exceptions instead.
error-handlingstack-python